Remove empty registerCommands override#2232
Merged
greg0ire merged 1 commit intoMay 18, 2026
Merged
Conversation
Member
|
It seems there are CI jobs failing. Please take a look at this guide for more on how to handle those. |
Contributor
Author
|
yes, but I ran all the tests, and everything I have control over passed (I think). The coding standards appear to be unrelated to my changes. |
Member
|
Ah yes it's caused by https://github.com/slevomat/coding-standard/releases/tag/8.29.0 I think. |
Member
|
I assigned copilot to it because I am AFK and it fixed it. |
greg0ire
approved these changes
May 18, 2026
greg0ire
requested review from
GromNaN,
SenseException,
derrabus,
dmaicher and
ostrolucky
ostrolucky
approved these changes
May 18, 2026
Member
|
Thanks @tacman ! |
Contributor
|
@greg0ire Thanks for this. Can this be tagged please 🙏 ? |
➕ Yeah a release would be awesome, our Symfony 8.1 upgrade is blocked now 😅 |
Member
|
Done |
@greg0ire Thank you for the swift response! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the empty
DoctrineBundle::registerCommands()override.Why
Symfony FrameworkBundle 8.1 deprecates overriding
Symfony\Component\HttpKernel\Bundle\Bundle::registerCommands(). DoctrineBundle 3.2.2 still overrides the method, but the implementation is empty, so removing it avoids the deprecation without changing command registration behavior.Fixes #2231.
Validation
php -l src/DoctrineBundle.phpvendor/bin/phpcs src/DoctrineBundle.phpvendor/bin/phpunitphp tests/console-application.php list --no-ansivendor/bin/phpstan analyse -v